[xcrysden] Compile fixes for newer gcc

Wolfram Quester xcrysden@democritos.it
Wed, 22 Mar 2006 19:09:11 +0100


--kfjH4zxOES6UT95V
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Tone,

thanks for reenabling the mailing list.
On Tue, Mar 21, 2006 at 03:05:21PM +0100, Tone Kokalj wrote:
> On Wed, 2006-03-01 at 19:46 +0100, Wolfram Quester wrote:
> > Hi altogether!
> >=20
> > I tried to compile XCrySDen here with gcc-4.0, but the compilation
> > failed with
> >=20
> > xcDisplayFunc.c:162: error: static declaration of =E2=80=98HandleDispla=
y=E2=80=99 follows non-static declaration
> > anaglyph.h:81: error: previous declaration of =E2=80=98HandleDisplay=E2=
=80=99 was here
> > xcDisplayFunc.c:164: error: static declaration of =E2=80=98CameraHome=
=E2=80=99 follows non-static declaration
> > anaglyph.h:82: error: previous declaration of =E2=80=98CameraHome=E2=80=
=99 was here
> > xcDisplayFunc.c:165: error: static declaration of =E2=80=98Normalise=E2=
=80=99 follows non-static declaration
> > anaglyph.h:83: error: previous declaration of =E2=80=98Normalise=E2=80=
=99 was here
> > xcDisplayFunc.c:166: error: static declaration of =E2=80=98CalcNormal=
=E2=80=99 follows non-static declaration
> > anaglyph.h:84: error: previous declaration of =E2=80=98CalcNormal=E2=80=
=99 was here
> > make[2]: *** [xcDisplayFunc.o] Error 1
> > make[2]: Leaving directory `/tmp/XC/C'
> > make[1]: *** [compile] Error 2
> > make[1]: Leaving directory `/tmp/XC/C'
> > make: *** [src-C] Error 2
> >=20
> >=20
> > The attached patch fixes this.=20
>=20
> Thank you very much for the patch. The even simpler solution is to
> simply
> delete these lines from anaglyph.h, as they are redundant.
>=20
> void HandleDisplay(struct Togl *togl);
> void CameraHome();
> void Normalise(XYZ *);
> XYZ  CalcNormal(XYZ,XYZ,XYZ);

But shouldn't you remove them from the .c-file then? I think these are
classical lines belonging into an .h file ;-).

With best wishes,

Wolfi
>=20
> Regards, Tone
>=20
> _______________________________________________
> XCrySDen mailing list
> XCrySDen@democritos.it
> http://www.democritos.it/mailman/listinfo/xcrysden

--kfjH4zxOES6UT95V
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEIZLGH0o2mefAfsQRAl3NAJ4jRyclxRfuR25sc5tgEzEHzxXLcwCfaMF1
oIKfI1gsu02hEhELKvku3BI=
=C2Ax
-----END PGP SIGNATURE-----

--kfjH4zxOES6UT95V--